Talk:Abuse filter helpers/Archives/2016

Adding "abusefilter-hidden-log" to list of permissions

Tracked in Phabricator:
Task T126129 resolved

Any reason why "abusefilter-hidden-log" is missing from the list of permissions for the "abusefilter-helper" user group? I was granted this right for some bot work I'm doing (among other reasons), and not being able to see all entries of Special:AbuseFilter/history is making it very difficult :)

abusefilter-helpers can already see private details of filters, so it seems nothing in the history would be inappropriate to reveal to them. It's only a matter of being able to easily see recent changes to private filters, which we can do manually but only through a tedious effort.

I don't think this page is well-watched, so pinging recent steward contributors MarcoAurelio and Ajraddatz. Thanks! — MusikAnimal ^talk 02:07, 3 February 2016 (UTC)

Sure, I've added it. It just lets you see the changes made to hidden filters, and since you can already see hidden filters it makes sense to also include that right. Ajraddatz (talk) 02:16, 3 February 2016 (UTC)

Ajraddatz Maybe it takes a minute to take affect? I still don't see anything at [1] — MusikAnimal ^talk 02:47, 3 February 2016 (UTC)

That's the correct right. Try logging out and back in again. If that doesn't work, I'll trouble-shoot... Ajraddatz (talk) 02:56, 3 February 2016 (UTC)

No dice :( Maybe it just takes a while. I'll check back in the morning. Thanks for your help! — MusikAnimal ^talk 03:31, 3 February 2016 (UTC)

@Ajraddatz and MusikAnimal: I have reverted the adition. The right that was added granted access to oversighted log entries, not to hidden log entries. AbuseFilter-helpers already have the abusefilter-log-private right which allows them to see log entries of private filters. Regards, —MarcoAurelio 11:33, 3 February 2016 (UTC)

@MarcoAurelio: That would explain why it didn't work! However something still isn't right as I am unable to see any private filters at Special:AbuseFilter/history. Maybe this is a bug? If I can view all private filters individually, why don't they show up in the history log? I can file a phab if necessary — MusikAnimal ^talk 15:43, 3 February 2016 (UTC)

I'll test with my test account and let you know my findings. —MarcoAurelio 17:09, 3 February 2016 (UTC)

Thanks, I was wondering if that was the case. It doesn't help that the extension uses "hidden" to describe both private filters, and oversighted log entries... Either way, I still can't find what the appropriate right or action is to enable this, but I can look more tomorrow. Ajraddatz (talk) 17:15, 3 February 2016 (UTC)

Still can't find anything. @MarcoAurelio and MusikAnimal: any luck? If not, maybe this is part of some other right that can't be given to the helper group :/ Ajraddatz (talk) 00:28, 5 February 2016 (UTC)

Sorry, I haven't tested yet. I'm having a look now. —MarcoAurelio 01:38, 5 February 2016 (UTC)

Hi, it's me socking :-P Well, I have tested with this account on meta and frwiki to see if I was able to see private filters, its logs and details, and I am able to; so I'm not sure why MusikAnimal is can not. We can continue testing tomorrow, because it's late for me now. For now I can confirm I can see those filters and related logs and details. Best regards, MarcoAurelio (test) (talk) 01:43, 5 February 2016 (UTC)

Can see history too. Best regards. MarcoAurelio (test) (talk) 01:45, 5 February 2016 (UTC)

@MarcoAurelio and MarcoAurelio (test): Really? Can you confirm that this page in particular shows up? I get "Le filtre que vous avez demandé est caché, et vous ne pouvez pas afficher son historique". By your wording I assume you did test that but just wanted to make sure. I can see the actual filter, so the abusefilter-helper right must be working in part – just can't see the history! @Ajraddatz: What about you? Mind trying on a test account? I will also ask some tech people on IRC — MusikAnimal ^talk 16:13, 5 February 2016 (UTC)

Hi. I can't see that particular filter history. That's strange. I'll review the filter config and userrights config and maybe I'll fill a bug. MarcoAurelio (test) (talk) 19:05, 6 February 2016 (UTC)

However I can see it with this account. It must be a right attached to sysops which is missing here. Will continue investigating. —MarcoAurelio 14:59, 7 February 2016 (UTC)

Adding (spamblacklistlog) to the package

While recently troubleshooting some cross-project bot issues I was able to determine that the "extension block" that a bot was getting was not from the abuse filter, but potentially from the spamblacklist. Unfortunately this is not available for viewing and I referred the operator/editor to the local project's admin team for assistance. Though not strictly related to abuse filters, SBL is related to abuse blocking in general - and as this is a read-only access extension I propose adding it to this group. Thank you, — xaosflux ^Talk 16:00, 29 October 2016 (UTC)

•  Support As proposer. — xaosflux ^Talk 16:04, 29 October 2016 (UTC)
• I think I can trust this set of users with this permission. —MarcoAurelio 11:30, 30 October 2016 (UTC)
•  Support Sounds reasonable. Same level of trust involved with viewing both logs, and as Xaosflux pointed out sometimes you might need to check both — MusikAnimal ^talk 01:52, 10 November 2016 (UTC)

Done. Hopefully I didn't accidentally give you all OS access again :-) – Ajraddatz (talk) 00:11, 13 November 2016 (UTC)

Thank you, verified that it does work, and no unusual permissions were found! — xaosflux ^Talk 00:17, 13 November 2016 (UTC)