Template talk:Closed request top

Latest comment: 5 years ago by E to the Pi times i in topic Proposal to update code

Proposal to update code

edit

Hi. I have designed a new template code for this. You can review it at User:MarcoAurelio/Sandbox (raw code). It adds a tally, automatic calculation of support percent and automatic categorization based on the base page name, and an optional "result" field for you to fill with "promoted"/"no consensus" and your signature, that if empty is hidden. I'd love to hear your opinions on changing the template code to this one. Further, I'd also create a {{closed request bottom}} and move this one to {{closed request top}} with redirect to this page, so you don't have to remember the page move. Ping bureaucrats: @Barras, M7, MF-Warburg, Matanya, Mentifisto, Sj, Thehelpfulone, and Tiptoety: and template experts @Patrick and Pathoschild:. Best regards. —MarcoAurelio 13:45, 8 August 2015 (UTC)Reply

When I close requests I don't add the tally usually and I never would do that on the top of the page. I just make a horizontal line and add the result below. However, I like the automatic categorization. -Barras talk 17:14, 8 August 2015 (UTC)Reply
The code looks fine to me. I made the tally optional, but feel free to revert if you don't want that:
{{closed request|7|2|0}}
The following discussion is preserved as an archive of a closed Meta-Wiki request. Please do not modify it.
Final tally:   Support: 7 •   Oppose: 2 •   Neutral: 0 (77.78%)

{{closed request}}
The following discussion is preserved as an archive of a closed Meta-Wiki request. Please do not modify it.

Pathoschild 17:43, 08 August 2015 (UTC)
Thank you Pathoschild. I also like that the tally be optional for people like Barras who prefers to add the result at the end. Thanks for the code review and tweaks. Best regards. —MarcoAurelio 18:35, 8 August 2015 (UTC)Reply
Hi Marco - I like this model, as long as the tally is optional. SJ talk  03:45, 19 August 2015 (UTC)Reply
@Sj: Yes, the tally and all that new stuff is optional for those who want to use it. It will continue to work as in the past. —MarcoAurelio 09:52, 19 August 2015 (UTC)Reply
I don't know if I understand it correctly. Will the templates {{closed request bottom}} and {{closed request top}} just contain the code which we already (sometimes) use in order to create this "This request is closed" box around a request? If yes, I dont think it's controversial to create them. --MF-W 22:14, 8 August 2015 (UTC)Reply
@MF-Warburg: Yes, the template appearance will not be changing. It just will let the closing bureaucrat to optionally add a tally and a result (if not, they won't show), and will automatically categorize the requestpage on the relevant category. —MarcoAurelio 11:13, 10 August 2015 (UTC)Reply
Sorry to be late but just wanted to say that this is a good idea, thanks for your work on it Marco and Pathos, it helps to summarise things more easily for those that would like to use it! Thehelpfulone 23:12, 30 August 2015 (UTC)Reply

  DoneMarcoAurelio 10:10, 19 August 2015 (UTC)Reply

@Pathoschild: There's a problem in the #switch argument for automatic categorization. Is there any way to avoid that the whole code for the categories be shown such as happened in here? Best regards, —MarcoAurelio 10:25, 19 August 2015 (UTC)Reply
Maybe this?MarcoAurelio 10:34, 19 August 2015 (UTC)Reply
Does it need to be subst'd? It seems cleaner to use the template as-is. —Pathoschild 14:43, 19 August 2015 (UTC)
No way to avoid that bunch of useless code then? Hum :-( —MarcoAurelio 10:23, 31 August 2015 (UTC)Reply
@MarcoAurelio: Actually, there is. The key is multilevel substitution. I've moved the category generation code to {{Closed request bottom}} because categories are conventionally placed on the bottom of pages.
This might be useful for all the bureaucrats to know so they don't accidentally add redundant categories when closing things. E to the Pi times i (talk) 00:09, 13 May 2019 (UTC)Reply
Return to "Closed request top" page.